Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancancan v2.1.0+ break the testing suite #973

Closed
wants to merge 2 commits into from
Closed

Cancancan v2.1.0+ break the testing suite #973

wants to merge 2 commits into from

Conversation

Eric-Guo
Copy link
Contributor

Root cause is cancancan PR 418

@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #973 into master will decrease coverage by 4.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   97.77%   93.12%   -4.65%     
==========================================
  Files         129      129              
  Lines        5878     5878              
==========================================
- Hits         5747     5474     -273     
- Misses        131      404     +273
Impacted Files Coverage Δ
app/uploaders/photo_uploader.rb 40% <0%> (-60%) ⬇️
app/controllers/api/v3/photos_controller.rb 50% <0%> (-50%) ⬇️
spec/api/topics_spec.rb 65.42% <0%> (-34.58%) ⬇️
app/controllers/photos_controller.rb 66.66% <0%> (-33.34%) ⬇️
spec/api/notifications_spec.rb 67.51% <0%> (-32.49%) ⬇️
spec/api/photos_spec.rb 68.42% <0%> (-31.58%) ⬇️
spec/controllers/photos_controller_spec.rb 69.23% <0%> (-30.77%) ⬇️
spec/api/nodes_spec.rb 75% <0%> (-25%) ⬇️
app/controllers/api/v3/notifications_controller.rb 78.26% <0%> (-21.74%) ⬇️
spec/api/users_spec.rb 86.01% <0%> (-13.99%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0d6e2...4eb18de. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 20, 2017 •
edited
Loading

Codecov Report

Merging #973 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         129      129           
  Lines        5878     5878           
=======================================
  Hits         5747     5747           
  Misses        131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0d6e2...3dfa627. Read the comment docs.

@Eric-Guo Eric-Guo mentioned this pull request Nov 20, 2017
Merged
@huacnlee huacnlee closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eric-Guo @huacnlee